Solution to the so called SI style paperdoll bug in BG with

NOTICE: This forum is archived as read only.
Please use the Github Discussions at https://github.com/exult/exult/discussions
Forum rules
NOTICE: This forum is archived as read only.
Please use the Github Discussions at https://github.com/exult/exult/discussions
Locked
Malignant Manor
Site Admin
Posts: 985
Joined: Thu May 14, 2020 1:34 pm

Solution to the so called SI style paperdoll bug in BG with

Post by Malignant Manor »

It affects both paperdoll types. It has seems to something to do with the free hand slot above it being open (detection problem?). You can test it easily by having a hand free open. BG paperdoll probably behaves exactly like the SI one.

With the BG paperdoll, if the Avatar's right hand is open, you can drag gloves onto the left hand ring slot. If the right hand doesn't have a ring, then you can drag it there as well.

If the Avatar's right hand is open and right hand ring is on, you can drag gloves onto the left or right hand slot. If the left ring is on, then this doesn't work when dragging to the left hand slot.



A quick fix is to edit actors.cc and put this:

else if (type == FIS_2Finger && (spot == lhand || spot == rhand) &&
(spots[lfinger] || spots[rfinger]))
return false;

before

// If in left or right hand allow it
else if (spot == lhand || spot == rhand)
return true;



This allows the person to only put gloves into their hands if a ring isn't present and seems to fix the bug through my testing. There probably needs to be some weird carefully worded "if" statements in order to do a better job than this.
marzo
Site Admin
Posts: 1925
Joined: Thu May 14, 2020 1:34 pm

Re: Solution to the so called SI style paperdoll bug in BG w

Post by marzo »

The actual root of the problem is in Actor::add: wherever the glove fits, the following block "forces" it to fit into the left finger:

Code: Select all

	if (type == FIS_2Finger) {	// Gloves?
		index = lfinger;
		two_fingered = true;
	}
I fixed this in CVS. I also changed the alternate spot for the BG glove to bring it more in line with SI gloves.
------
Marzo Sette Torres Junior
aka Geometrodynamic Dragon
[url=http://www.catb.org/~esr/faqs/smart-questions.html]How To Ask Questions The Smart Way[/url]
Viking

Re: Solution to the so called SI style paperdoll bug in BG w

Post by Viking »

Could this be put into a snapshot?
Malignant Manor
Site Admin
Posts: 985
Joined: Thu May 14, 2020 1:34 pm

Re: Solution to the so called SI style paperdoll bug in BG w

Post by Malignant Manor »

Could this be put into a snapshot?
It's already available in the download section.
marzo
Site Admin
Posts: 1925
Joined: Thu May 14, 2020 1:34 pm

Re: Solution to the so called SI style paperdoll bug in BG w

Post by marzo »

It will, eventually; it very likely is there already.
------
Marzo Sette Torres Junior
aka Geometrodynamic Dragon
[url=http://www.catb.org/~esr/faqs/smart-questions.html]How To Ask Questions The Smart Way[/url]
Locked