#exult logs

#exult full logs for 8 Apr 2020 (GMT)

Archive Today Yesterday Tomorrow
Exult homepage

[00:41:04] --> BrainChild has joined #exult
[00:42:37] --> Rottingbeef-2 has joined #exult
[00:58:33] <-- BrainChild has left IRC (Ping timeout: 264 seconds)
[02:54:50] --> BrainChild has joined #exult
[03:12:20] <-- BrainChild has left IRC (Ping timeout: 265 seconds)
[03:14:18] --> Rottingbeef-2_ has joined #exult
[03:16:43] <-- Rottingbeef-2 has left IRC (Ping timeout: 256 seconds)
[04:56:12] <-- Rottingbeef-2_ has left IRC ()
[05:08:27] --> BrainChild has joined #exult
[05:42:08] <-- BrainChild has left IRC (Ping timeout: 256 seconds)
[06:01:44] --> BrainChild has joined #exult
[06:05:22] <-- Dominus has left IRC (Ping timeout: 256 seconds)
[06:14:37] --> Dominus has joined #exult
[06:14:38] <-- Dominus has left IRC (Changing host)
[06:14:38] --> Dominus has joined #exult
[06:14:38] --- ChanServ gives channel operator status to Dominus
[08:04:53] <-- Lightkey has left IRC (Ping timeout: 260 seconds)
[08:18:42] --> Lightkey has joined #exult
[09:41:44] <-- BrainChild has left IRC (Remote host closed the connection)
[09:42:15] --> BrainChild has joined #exult
[10:21:30] <-- BrainChild has left IRC (Ping timeout: 240 seconds)
[10:22:03] --> BrainChild has joined #exult
[10:26:52] <-- BrainChild has left IRC (Ping timeout: 250 seconds)
[10:42:40] --> BrainChild has joined #exult
[13:27:51] --> Rottingbeef-2 has joined #exult
[13:28:15] <-- BrainChild has left IRC (Remote host closed the connection)
[13:29:38] --> BrainChild has joined #exult
[13:34:33] <-- BrainChild has left IRC (Ping timeout: 264 seconds)
[14:06:59] --> BrainChild has joined #exult
[14:19:43] <-- BrainChild has left IRC (Ping timeout: 256 seconds)
[14:53:52] --> Marzo has joined #exult
[15:24:59] --> BrainChild has joined #exult
[15:48:39] <-- BrainChild has left IRC (Remote host closed the connection)
[15:49:06] --> BrainChild has joined #exult
[15:50:22] <-- BrainChild has left IRC (Read error: Connection reset by peer)
[15:50:33] --> BrainChild has joined #exult
[15:55:20] <-- BrainChild has left IRC (Ping timeout: 250 seconds)
[16:23:53] --> BrainChild has joined #exult
[16:37:22] <-- BrainChild has left IRC (Ping timeout: 250 seconds)
[18:06:50] <-- Marzo has left IRC (Ping timeout: 240 seconds)
[18:26:19] --> Marzo has joined #exult
[18:34:46] --> BrainChild has joined #exult
[18:36:04] <Dominus> Marzo, this is weird, but do you have any idea why this commit https://github.com/exult/exult/commit/646782635c06fa85b0f2a06201d7bdb78fa124e9 changed the spells Cantra and Batlin use in the crystal ball scene?
[18:54:07] <Marzo> Dominus: Can you try changing both instances of ¨add_info.is_on_fire()¨ to ¨(!add_info.is_spell() && add_info.is_on_fire())¨ and see if it still happens?
[18:54:40] <Marzo> This would be a quick hack to test, a proper fix probably lies somewhere else up the chain
[18:57:37] <Dominus> yes, that's changing it back to the way it was before
[18:59:15] <Dominus> I'm amazed by things like that, seemingly unrelated thing bugs somewhere else... but again, hooray for my snapshot archive which allows quick regression testing :)
[19:00:02] <Marzo> To be fair, I think that this change can go as suggested
[19:00:41] <Marzo> Because spells generally are not meant ti be seen by the player anyway
[19:01:23] <Marzo> This will filter out the spells from the check, but still prevent lit torches from being put on backpacks
[19:02:54] <Dominus> will you add this fix and back merge it to master?
[19:03:15] <Marzo> You can go ahead
[19:03:41] <Marzo> Still working on my shortcut bar rework, and right now, input is not working at all :(
[19:03:53] <Dominus> ouch
[19:04:33] <Dominus> I'll commit to master and maybe you can merge back to merge-devel... I'm not really good at that merge stuff without breaking things :)
[19:04:52] <Marzo> You can add it to one and cherry-pick to the other
[19:05:04] <Dominus> ah, yes, that I can do
[19:05:21] <Marzo> That also helps git to know that it can skip a commit when merging, I think
[19:06:04] <Marzo> I would recommend adding it to merged-devel and cherry-picking to master
[19:06:25] <Dominus> yes, doing that
[19:07:10] <-- BrainChild has left IRC (Ping timeout: 258 seconds)
[19:49:10] <Marzo> @Dominus: out of curiosity, what happens on Exult when you quickly press left-right-left on the mouse within a short period of time? It seems to me like the double click will still happen in some cases
[19:49:22] <Marzo> But the code is a mess
[20:13:06] --> BrainChild has joined #exult
[20:20:38] <Dominus> marzo, yes, I can confirm this on the shortcut bar
[20:20:56] <Dominus> and on the avatar
[20:21:11] <Marzo> This still happens on the new code, and is due to SDL this time
[20:21:37] <Dominus> and curiously, somehow the shortcutbar map opens the dark path map in the savegame here
[20:21:47] <Marzo> One thing I am not liking is that the user event for the single click is delaying all other inputs until it finishes
[20:22:07] <Dominus> yes, that is a bit off putting
[20:24:21] <Marzo> For example, single clicking with the mouse on an item, then immediately pressing esc to bring the main menu, eats the esc press
[20:24:35] <Marzo> Does this also happen with the old code?
[20:25:35] <Dominus> no
[20:26:11] <Dominus> on the shortcutbar the ESC keye eats the click actually
[20:27:01] <Dominus> on another object in the game, the ESC key reacts first and then when you close the game menu the name of the object gets painted
[20:28:53] <Marzo> Normally I would have no issue with that, but the delay is noticeable
[20:30:19] <Marzo> Reducing the delay a bit helps hide the issue, but too short a delay can make double-clicking hard
[20:30:59] <Marzo> But to be fair, seems like double-click delays are measured from the start of the first click (mouse down) to the start of the second click (second mouse down)
[20:32:07] <Dominus> Marzo, I have a tiny little shortcutbar fix, in case SB_ITEM_MAP -> gwin->activate_item(178,0); to make sure only the first shape frame gets used :) - I guess now is not the time to commit this? Since this also affects master, should I mcommit only for this and you merge back or or ?
[20:32:40] <Dominus> I do remember that this mouse down stuff cost me a lot of nerves when I tried to tweak the shortcutbar :)
[20:33:24] <Marzo> You can send it to master and I will apply a local equivalent
[20:33:33] <Dominus> k
[20:33:57] <Marzo> Because the code is completely different now
[20:34:17] <Marzo> This is mainly for SI, I guess?
[20:34:36] <Dominus> that sounds interesting - again looking forward to see what you've done with it
[20:35:07] <Marzo> Assuming I can get everything working how I want
[20:35:40] <Dominus> yes, this only affects SI, somehow if only the shape number was entered it uses the frames 1 upwards, depending on what other maps are there, but does not begin with 0
[20:38:02] <Marzo> Hm. I have a theory on what may be causing the delay
[20:38:57] <Dominus> the delay is really noticeable on current code on the shortcut bar...
[20:41:56] <Marzo> Now imagine that for every single click and you will see what I am seeing
[20:42:26] <Dominus> yes, that's not good :(
[20:52:16] <Marzo> Yeah, will have to investigate more
[20:52:38] <Marzo> Just ran into an issue where the game gets frozen expecting another click to happen
[20:52:55] <Marzo> Guess this code is not that much better than what we had previously
[20:53:46] <Marzo> I will modify our old code to improve it and make it better, but I will ditch the approach Litchie used
[20:54:20] <Dominus> I feel bad for the time you wasted on this :(
[20:54:57] <Marzo> The main issue is that SDL is too low level to provide us with a double-click event
[20:56:49] <Marzo> But to be fair, if I can get the shortcut bar working with the new code I wrote for it with minimal changes to Exult input, I will be happy
[20:57:18] <Marzo> Because that code is another one that should be nuked from orbit
[21:04:09] <Marzo> Hm
[21:04:14] <Marzo> Here is a random thought
[21:05:24] <Marzo> Maybe instead of double-clicking on the shortcut bar we could have ctrl+clicking on PC, or long-press on touch devices?
[21:05:55] <Marzo> Because tap and hold is a much easier input than double-tap
[21:06:50] <Dominus> hmm, the touch and hold might work, I'd have to test on a real device to see who that fares in real life, though
[21:06:53] <Marzo> Anyway, reverted my changes to exult.cc and everything is back to how it was yesterday (everything but double-clicks work on shortcutbar)
[21:06:59] <Dominus> the ctrl-click I don't like much
[21:11:48] <Marzo> To be fair, the double-click actions are mostly cheat actions
[21:13:24] <Dominus> yes but the point of the shortcutbar is to only use the mouse (well, only the finger) but when you use an extra key it lessens it IMO
[21:16:04] <Marzo> Anyway, off to bed
[21:16:06] <Marzo> Good night
[21:16:14] <Dominus> night
[21:21:10] <-- Marzo has left IRC (Ping timeout: 256 seconds)
[23:17:16] <-- BrainChild has left IRC (Remote host closed the connection)
[23:19:11] --> BrainChild has joined #exult
[23:24:04] <-- BrainChild has left IRC (Ping timeout: 256 seconds)
[23:50:56] --> BrainChild has joined #exult